Repository navigation
feat(needs): COMP-2-2 three decision rows in Braucht dich - #1455
Merged
Merged
Conversation
Failing tests: the pane must always show the Geld, Installieren and Loeschen sentences, answer a delete question inside its row, and keep an unmatched question in the list. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the money one-liner while no money question is open Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::answers a delete question from its own row Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::keeps a question that matches no row in the list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… rows Three rows sit above the question list, each with one sentence and "Keine offene Entscheidung." while empty. A question classified as money, install or delete moves into its row and is answered with the same Ask field (moved to Ask.tsx unchanged); other questions stay in the list. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the money one-liner while no money question is open Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::answers a delete question from its own row Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::keeps a question that matches no row in the list Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ing or unreadable Finding R1455-G1: the three lanes said "Keine offene Entscheidung." next to the loading and offline states, although nothing had been read. Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list cannot be read Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list is loading Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
While the list loads or cannot be read, the Geld, Installieren and Loeschen lanes claimed "Keine offene Entscheidung." beside the loading or offline state. They now render only when questions are open or the read finished without error (finding R1455-G1). Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list cannot be read Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list is loading Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cuarroc
marked this pull request as ready for review
October 15, 2026 00:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Cuarroc
added
the
review-ok
Owner
Author
Owner
Author
|
@Mergifyio queue |
30 of 46 tasks
Contributor
Merge Queue Status
This pull request spent 15 minutes 39 seconds in the queue, including 14 minutes 56 seconds running CI. Required conditions to merge
|
This was referenced Oct 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Die Spalte „Braucht dich" zeigt jetzt immer drei Zeilen: Geld, Installieren und Löschen, jede mit einem Satz, dass sie deine Freigabe braucht. Passt eine offene Frage zu einer Zeile, steht sie dort und lässt sich mit demselben Antwortfeld beantworten. Alle anderen Fragen bleiben in der bisherigen Liste, und es wird nichts ausgegeben, installiert oder gelöscht.
Report
Was geändert wurde (COMP-2-2)
DecisionLane.tsx(neu): eine Zeile je Klasse (money, install, delete) mit Überschrift, Satz und „Keine offene Entscheidung.", solange leer.Ask.tsx(neu):Ask,parseOptionsundageunverändert ausNeedsYou.tsxverschoben, damit Liste und Zeilen dasselbe Antwortfeld nutzen.NeedsYou.tsx: drei Zeilen immer über der Liste (auch beim Laden, leer oder offline); Fragen lautclassifyQuestionlanden genau einmal in ihrer Zeile, Klasseotherbleibt in der Liste.onAnswerunverändert.texts.ts(neu),needs.css(3 Zeilen). Keine Ziffern im Zeilentext,Nichts offenbleibt im leeren Zustand.classify.ts,answer_question,api.rs, Datenbank, kein Rust.Asketwa 95 Zeilen.RE source: Composio Agent Orchestrator (Apache-2.0) lane idea only; no code copied
Belege
ab0f4326allein hat drei rote Tests; Kopf8def5677grün.npx --no-install vitest run src/screens/leitstand/needs src/i18n/hardcoded.test.ts: Exit 0 (35 Tests)npm run typecheck: Exit 0;npm run build: Exit 0bash scripts/ci/red-first.sh: Exit 0;git diff --check: Exit 0bash scripts/ci/gates.sh lane prepush: erster Lauf bisfe-testgrün,denkraumROT (Playwright D4Test timeout of 30000ms exceeded, Server-Last etwa 40, Test nicht berührt); danachgates.sh --from denkraum lane prepushbei Last 13: Exit 0 (denkraum, clippy, rust-suite grün). Derselbe D4-Test hat bei einem Commit-Versuch unter Last ebenfalls das Zeitlimit gerissen und beim nächsten bestanden.Abweichungen zu
glass/Main.dc.html(Sicht auf Screenshots)--g-hair,--g-r-card,--g-muted.Architecture drift: keine neue Meldung.
Review-Stand: Review: ausstehend (Stufe B). Autor ist Anthropic (Claude Sonnet 5.5), der Prüfer muss außerhalb Anthropic liegen; Root ordnet ihn zu.
NICHT ABGEDECKT
#[cfg(windows)]-Tests und die Windows-Arme von clippy laufen auf Linux nicht; die Windows-Bahn läuft in der Merge-Queue.linux(nurprepushlokal gelaufen).DecisionLane.test.tsx; die Zeilen sind überNeedsYou.test.tsxabgedeckt.Fix round 1 (NACHBESSERN, Befund R1455-G1, mittel; unabhängig von GLM 5.3, Kimi K3 und Gemini 3.8 Flash gefunden, von Root bestätigt)
NeedsYou.tsxzeigte die drei Entscheidungsspuren immer; beim Laden oder offline ohne Fragen stand dort dreimal "Keine offene Entscheidung." neben dem Lade- bzw. Offline-Zustand.open.length > 0 || (error === null && !loading)); sonst nichts.0ced7749(Test, rot auf8def5677),d49a4b0c(Fix).NeedsYou.test.tsx::shows no decision lane claiming nothing is open while the list cannot be readund::shows no decision lane claiming nothing is open while the list is loading.npx vitest run src/screens/leitstand/needs/NeedsYou.test.tsxauf8def5677+ nur Test: Exit 1, 2 von 16 Tests rot (3 statt 0 Treffer für "Keine offene Entscheidung.").npx vitest run src/screens/leitstand/needsExit 0 (22 Tests);bash scripts/ci/gates.sh lane prepushExit 0 am Kopfd49a4b0c; Push mitgit ls-remotebestätigt.git diff --shortstat origin/main...HEAD(Fix-Runde, Grenze 400).🤖 Generated with Claude Code
Root review disposition (round 1 on 8def567, delta round on d49a4b0, 15.10.2026)
Author family: Anthropic (Claude). Tier B (frontend). Round-1 reviews on
8def5677: Cohere north-mini-code (kilo), Alibaba Qwen3-Coder-Next, Zhipu GLM 5.3, Moonshot Kimi K3, Google Gemini 3.8 Flash (OpenRouter). Delta review ond49a4b0c: Zhipu GLM 5.3 (OpenRouter,gh pr diff 1455at that head) confirms the fix ("empty/error/loading states correctly suppress the lanes").classify.tsmissing / preflight unclassifiedLANES satisfiesdoes not enforce exhaustivenessSize: 207+96 = 303 lines after the fix round forced by R1455-G1 (initial 284; the forced-fix limit is 400). No open high or medium finding.